fix(#4178): nested versioned events now dispatch to correct projection apply overload#4179
Merged
jeremydmiller merged 2 commits intoJasperFx:masterfrom Mar 23, 2026
Merged
fix(#4178): nested versioned events now dispatch to correct projection apply overload#4179jeremydmiller merged 2 commits intoJasperFx:masterfrom
jeremydmiller merged 2 commits intoJasperFx:masterfrom
Conversation
Member
|
I think that's fine, but let CI run on it now |
Member
|
Yeah, sorry, no. That causes some regression errors. |
Contributor
Author
Ah! Leave it with me, the tests passed locally but maybe they weren't all discovered |
Contributor
Author
Should be satisfactory now, I hope! |
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4178
EventNamingStyle.ClassicTypeName (default option) derives the type alias from the simple class name only. Both
V1.CustomerCreatedandV2.CustomerCreatedcollapse to "customer_created", so only one CLR type can occupy the _byEventName alias cache in EventGraph.From EventGraph.cs, line 72:
_byEventName.OnMissing = name => AllEvents().FirstOrDefault(x => x.EventTypeName == name);EventDocumentStorage.Resolve()/ResolveAsync()only fall back to reading the dotnet_type column (index 2) when the alias lookup returns null. Because the alias always matches something (the cache winner), dotnet_type was never consulted.--
Really, my project should have used
opts.Events.EventNamingStyle = EventNamingStyle.SmarterTypeName;but switching to that now would require modifying themt_eventstable, which I don't feel is ideal. I suppose there may be an argument that SmarterTypeName should be default? (https://martendb.io/events/storage#event-type-names).